[action] [PR:4172] [RouteOrch] fix performance regression in ResponsePublisher#4313
Merged
mssonicbld merged 1 commit intosonic-net:202511from Mar 9, 2026
Merged
Conversation
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Fix performance regression caused by sonic-net#3066 : setBuffered wasn't using Redis pipeline correctly. Add a flag to directly write attributes passed by the caller of publish API avoiding Redis HGET which breaks Redis pipeline. **Why I did it** Fix performance degradation observed in BGP suppress test. **How I verified it** - t1-lag BGP route test. Starting BGP sessions config bgp startup all and profile. - BGP suppress FIB sonic-mgmt test <img width="2082" height="1444" alt="image" src="https://github.com/user-attachments/assets/752c1ae0-a44e-4aaa-baba-17ce584d05c9" /> Signed-off-by: Sonic Build Admin <[email protected]>
Collaborator
Author
|
Original PR: #4172 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
andrewsapronov
pushed a commit
to netbergtw/sonic-swss
that referenced
this pull request
Mar 12, 2026
…t#4313) <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Fix performance regression caused by sonic-net#3066 : setBuffered wasn't using Redis pipeline correctly. Add a flag to directly write attributes passed by the caller of publish API avoiding Redis HGET which breaks Redis pipeline. **Why I did it** Fix performance degradation observed in BGP suppress test. **How I verified it** - t1-lag BGP route test. Starting BGP sessions config bgp startup all and profile. - BGP suppress FIB sonic-mgmt test <img width="2082" height="1444" alt="image" src="https://github.com/user-attachments/assets/752c1ae0-a44e-4aaa-baba-17ce584d05c9" /> Signed-off-by: Sonic Build Admin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix performance regression caused by #3066 : setBuffered wasn't using Redis pipeline correctly.
Add a flag to directly write attributes passed by the caller of publish API avoiding Redis HGET which breaks Redis pipeline.
Why I did it
Fix performance degradation observed in BGP suppress test.
How I verified it
Signed-off-by: Sonic Build Admin [email protected]